From 83a935c655ad63acd742eabaa7cde33d137113d6 Mon Sep 17 00:00:00 2001 From: hrbrmstr Date: Wed, 13 Nov 2019 07:24:46 -0500 Subject: [PATCH] Added Maarten Demeyer to DESCRIPTION --- .Rbuildignore | 1 + CRAN-RELEASE | 2 ++ DESCRIPTION | 7 ++++--- cran-comments.md | 26 +++++--------------------- 4 files changed, 12 insertions(+), 24 deletions(-) create mode 100644 CRAN-RELEASE diff --git a/.Rbuildignore b/.Rbuildignore index be81d09..715fe01 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -8,3 +8,4 @@ ^CONDUCT\.md$ ^cran-comments\.md$ ^docs$ +^CRAN-RELEASE$ diff --git a/CRAN-RELEASE b/CRAN-RELEASE new file mode 100644 index 0000000..95bec4a --- /dev/null +++ b/CRAN-RELEASE @@ -0,0 +1,2 @@ +This package was submitted to CRAN on 2019-11-13. +Once it is accepted, delete this file and tag the release (commit 5c381da816). diff --git a/DESCRIPTION b/DESCRIPTION index 2bc4124..3b03b4d 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,15 +1,16 @@ Package: ndjson Type: Package Title: Wicked-Fast Streaming 'JSON' ('ndjson') Reader -Version: 0.8.0.9000 -Date: 2019-09-17 +Version: 0.8.0 +Date: 2019-11-13 Authors@R: c( person("Bob", "Rudis", email = "bob@rud.is", role = c("aut", "cre"), comment = c(ORCID = "0000-0001-5670-2640")), person("Niels", "Lohmann", role = "aut", comment = "C++ json parser"), person("Deepak", "Bandyopadhyay", role = "aut", comment = "C++ gzstream"), person("Lutz", "Kettner", role = "aut", comment = "C++ gzstream"), person("Neal", "Fultz", role = "ctb", - comment = "Rcpp integration") ) + comment = "Rcpp integration"), person("Maarten", "Demeyer", role = "ctb", + comment = "dtplyr cleanup")) Maintainer: Bob Rudis Description: Streaming 'JSON' ('ndjson') has one 'JSON' record per-line and many modern 'ndjson' files contain large numbers of records. diff --git a/cran-comments.md b/cran-comments.md index 92dcfb5..748565a 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,28 +1,12 @@ ## Test environments -* local macOS (10.13.4 beta 3) install, R 3.4.3 (clang) -* local ubuntu 16.04, R 3.4.3 (g++-7) -* Travis-CI (linux) https://travis-ci.org/hrbrmstr/ndjson +* local OS X install, R 3.6.1 +* ubuntu 14.04 (on travis-ci), R 3.6.1 * win-builder (devel and release) ## R CMD check results -0 errors | 0 warnings | 1 note (Maintainer) +0 errors | 0 warnings | 1 note -* This is an update +* This is a bug-fix release. -## Reverse dependencies - -- streamR (passed check; it has no tests) - -## General notes - -- License change to MIT -- Update core C++ library the pkg uses to 3.1.1 -- Removed #pragmas from said C++ library that was causing - CRAN issues due to the new "show all warnings" policy - -Re-submitting as a result of me being daft and not having -the revdep check dir in .Rbuildignore (dir has been removed). - -thx, #sigh and apologies to the CRAN team for making you deal -with two resubmissions today. +Per note from Kurt I've fixed the {dtplyr} issues.