Browse Source

forgot 8050 in docker

0.6.0
boB Rudis 1 year ago
parent
commit
9a328819fa
No known key found for this signature in database GPG Key ID: 1D7529BE14E2BBA9
2 changed files with 3 additions and 3 deletions
  1. +1
    -1
      R/docker-splash.r
  2. +2
    -2
      tests/testthat/test-splash.R

+ 1
- 1
R/docker-splash.r View File

@@ -42,7 +42,7 @@ start_splash <- function(tag="3.2", container_name = "splashr", remove=FALSE) {
docker$container$run(
image = sprintf("scrapinghub/splash:%s", tag),
name = container_name,
ports = c("5023:5023", "8051:8051"),
ports = c("5023:5023", "8051:8051", "8050:8050"),
detach = TRUE,
rm = remove,
tty = TRUE


+ 2
- 2
tests/testthat/test-splash.R View File

@@ -6,7 +6,7 @@ test_that("we can do something", {
test_url <- "http://localhost:8050/"

xpct <- function(x) {
spact <- splash_active()
spact <- splash_active(splash_local)
expect_that(spact, equals(TRUE))
expect_that(length(splash_debug()), equals(7))
expect_that(length(splash_version()), equals(9))
@@ -17,7 +17,7 @@ test_that("we can do something", {
expect_that(render_har(url = test_url), is_a("har"))
}

spact <- splash_active()
spact <- splash_active(splash_local)

if (spact) {
xpct()


Loading…
Cancel
Save