Browse Source

forgot 8050 in docker

boB Rudis 9 months ago
parent
commit
9a328819fa
No known key found for this signature in database
2 changed files with 3 additions and 3 deletions
  1. 1
    1
      R/docker-splash.r
  2. 2
    2
      tests/testthat/test-splash.R

+ 1
- 1
R/docker-splash.r View File

@@ -42,7 +42,7 @@ start_splash <- function(tag="3.2", container_name = "splashr", remove=FALSE) {
42 42
   docker$container$run(
43 43
     image = sprintf("scrapinghub/splash:%s", tag),
44 44
     name = container_name,
45
-    ports = c("5023:5023", "8051:8051"),
45
+    ports = c("5023:5023", "8051:8051", "8050:8050"),
46 46
     detach = TRUE,
47 47
     rm = remove,
48 48
     tty = TRUE

+ 2
- 2
tests/testthat/test-splash.R View File

@@ -6,7 +6,7 @@ test_that("we can do something", {
6 6
   test_url <- "http://localhost:8050/"
7 7
 
8 8
   xpct <- function(x) {
9
-    spact <- splash_active()
9
+    spact <- splash_active(splash_local)
10 10
     expect_that(spact, equals(TRUE))
11 11
     expect_that(length(splash_debug()), equals(7))
12 12
     expect_that(length(splash_version()), equals(9))
@@ -17,7 +17,7 @@ test_that("we can do something", {
17 17
     expect_that(render_har(url = test_url), is_a("har"))
18 18
   }
19 19
 
20
-  spact <- splash_active()
20
+  spact <- splash_active(splash_local)
21 21
 
22 22
   if (spact) {
23 23
     xpct()

Loading…
Cancel
Save