From 9a328819fa45d1c28b731749cc67998633cd2a2b Mon Sep 17 00:00:00 2001 From: hrbrmstr Date: Sun, 13 Jan 2019 17:16:31 -0500 Subject: [PATCH] forgot 8050 in docker --- R/docker-splash.r | 2 +- tests/testthat/test-splash.R | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/R/docker-splash.r b/R/docker-splash.r index 184eb17..3c63f0f 100644 --- a/R/docker-splash.r +++ b/R/docker-splash.r @@ -42,7 +42,7 @@ start_splash <- function(tag="3.2", container_name = "splashr", remove=FALSE) { docker$container$run( image = sprintf("scrapinghub/splash:%s", tag), name = container_name, - ports = c("5023:5023", "8051:8051"), + ports = c("5023:5023", "8051:8051", "8050:8050"), detach = TRUE, rm = remove, tty = TRUE diff --git a/tests/testthat/test-splash.R b/tests/testthat/test-splash.R index 9f47bcd..7534d98 100644 --- a/tests/testthat/test-splash.R +++ b/tests/testthat/test-splash.R @@ -6,7 +6,7 @@ test_that("we can do something", { test_url <- "http://localhost:8050/" xpct <- function(x) { - spact <- splash_active() + spact <- splash_active(splash_local) expect_that(spact, equals(TRUE)) expect_that(length(splash_debug()), equals(7)) expect_that(length(splash_version()), equals(9)) @@ -17,7 +17,7 @@ test_that("we can do something", { expect_that(render_har(url = test_url), is_a("har")) } - spact <- splash_active() + spact <- splash_active(splash_local) if (spact) { xpct()