Browse Source

fixup some harbor/docker things that were broken

master
boB Rudis 3 years ago
parent
commit
9c5f807b5b
3 changed files with 4 additions and 3 deletions
  1. +1
    -0
      NAMESPACE
  2. +2
    -2
      R/docker.r
  3. +1
    -1
      R/splashr-package.R

+ 1
- 0
NAMESPACE View File

@@ -19,6 +19,7 @@ export(splash_debug)
export(start_splash)
export(stop_splash)
export(writeHAR)
import(harbor)
import(httr)
import(magick)
import(purrr)


+ 2
- 2
R/docker.r View File

@@ -8,7 +8,7 @@
#' stop_splash(splash_container)
#' }
install_splash <- function() {
harbor::docker_pull(localhost, "scrapinghub/splash")
harbor::docker_pull(harbor::localhost, "scrapinghub/splash")
}

#' Start a Splash server Docker container
@@ -24,7 +24,7 @@ install_splash <- function() {
#' stop_splash(splash_container)
#' }
start_splash <- function() {
harbor::docker_run(localhost, image = "scrapinghub/splash", detach = TRUE,
harbor::docker_run(harbor::localhost, image = "scrapinghub/splash", detach = TRUE,
docker_opts = "-p 5023:5023 -p 8050:8050 -p 8051:8051")
}



+ 1
- 1
R/splashr-package.R View File

@@ -14,7 +14,7 @@
#' @name splashr
#' @docType package
#' @author Bob Rudis (bob@@rud.is)
#' @import purrr httr magick
#' @import purrr httr magick harbor
#' @importFrom HARtools writeHAR HARviewer renderHARviewer HARviewerOutput
#' @importFrom xml2 read_html url_parse
#' @importFrom jsonlite fromJSON


Loading…
Cancel
Save