diff --git a/CRAN-RELEASE b/CRAN-RELEASE index 30e1f5b..aebd53a 100644 --- a/CRAN-RELEASE +++ b/CRAN-RELEASE @@ -1,2 +1,2 @@ -This package was submitted to CRAN on 2019-07-21. -Once it is accepted, delete this file and tag the release (commit ddb8e53dac). +This package was submitted to CRAN on 2019-07-28. +Once it is accepted, delete this file and tag the release (commit 2143fd4a15). diff --git a/R/create.R b/R/create.R index 63d9692..23be422 100644 --- a/R/create.R +++ b/R/create.R @@ -43,7 +43,7 @@ tdigest <- function(vec, compression=100) { #' @param probs numeric vector of probabilities with values in range 0:1 #' @export #' @return a `numeric` vector containing the requested quantile values -#' @references +#' @references [Computing Extremely Accurate Quantiles Using t-Digests](https://arxiv.org/abs/1902.04023) #' @examples #' set.seed(1492) #' x <- sample(0:100, 1000000, replace = TRUE) @@ -95,7 +95,7 @@ print.tdigest <- function(x, ...) { #' (~1 million datapoints). Defaults to 100. #' @export #' @return a `tdigest` object -#' @references +#' @references [Computing Extremely Accurate Quantiles Using t-Digests](https://arxiv.org/abs/1902.04023) #' @examples #' td <- td_create(10) td_create <- function(compression=100) { diff --git a/README.Rmd b/README.Rmd index 7f17f5a..b5b0b2e 100644 --- a/README.Rmd +++ b/README.Rmd @@ -10,6 +10,7 @@ hrbrpkghelpr::global_opts() ```{r badges, results='asis', echo=FALSE, cache=FALSE} hrbrpkghelpr::stinking_badges() ``` + [![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.3357770.svg)](https://doi.org/10.5281/zenodo.3357770) # tdigest diff --git a/README.md b/README.md index 4549549..b50c86e 100644 --- a/README.md +++ b/README.md @@ -12,10 +12,16 @@ Status](https://travis-ci.org/hrbrmstr/tdigest.svg?branch=master)](https://travi status](https://ci.appveyor.com/api/projects/status/github/hrbrmstr/tdigest?svg=true)](https://ci.appveyor.com/project/hrbrmstr/tdigest) [![Coverage Status](https://codecov.io/gh/hrbrmstr/tdigest/branch/master/graph/badge.svg)](https://codecov.io/gh/hrbrmstr/tdigest) +[![cran +checks](https://cranchecks.info/badges/worst/tdigest)](https://cranchecks.info/pkgs/tdigest) +[![CRAN +status](https://www.r-pkg.org/badges/version/tdigest)](https://www.r-pkg.org/pkg/tdigest) ![Minimal R Version](https://img.shields.io/badge/R%3E%3D-3.5.0-blue.svg) ![License](https://img.shields.io/badge/License-MIT-blue.svg) +[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.3357770.svg)](https://doi.org/10.5281/zenodo.3357770) + # tdigest Wicked Fast, Accurate Quantiles Using ‘t-Digests’ @@ -156,9 +162,9 @@ microbenchmark::microbenchmark( r_quantile = quantile(x, c(0, 0.01, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.99, 1)) ) ## Unit: microseconds -## expr min lq mean median uq max neval -## tdigest 5.321 7.033 19.31994 12.81 27.21 78.235 100 -## r_quantile 63712.810 66272.069 69917.07935 67808.48 70713.83 136526.086 100 +## expr min lq mean median uq max neval +## tdigest 4.965 6.415 18.14998 9.289 26.7875 75.129 100 +## r_quantile 59227.919 62490.644 65431.59551 64246.659 66578.5085 127656.518 100 ``` ## tdigest Metrics @@ -167,7 +173,7 @@ microbenchmark::microbenchmark( | :----------- | -------: | ---: | --: | ---: | ----------: | ---: | -------: | ---: | | C | 3 | 0.27 | 350 | 0.65 | 46 | 0.36 | 26 | 0.11 | | R | 6 | 0.55 | 140 | 0.26 | 31 | 0.24 | 139 | 0.57 | -| Rmd | 1 | 0.09 | 36 | 0.07 | 40 | 0.31 | 52 | 0.21 | +| Rmd | 1 | 0.09 | 36 | 0.07 | 40 | 0.31 | 53 | 0.22 | | C/C++ Header | 1 | 0.09 | 10 | 0.02 | 10 | 0.08 | 26 | 0.11 | ## Code of Conduct diff --git a/cran-comments.md b/cran-comments.md index 8422005..0afac96 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -11,17 +11,6 @@ * This is a new release. -- README warning fixed. -- Zero sized array warning fixed - -Hey CRAN team members! There is no rush -to get this processed whatsoever so if -there are package authors who have -asked for any acceleration of their -package evaluation please do not hesitate -to put them ahead of this in the queue. - -It's passed more than a few gauntlets -(that bullet list at the top is legit) but -if I missed anything I apologize in advance -and will work to correct ASAP. \ No newline at end of file +This DESCRIPTION file has no Maintainer in it. +I'm also pretty sure the previous submission +had no Maintainer in it. \ No newline at end of file diff --git a/man/td_create.Rd b/man/td_create.Rd index 1efa60a..c24fd0b 100644 --- a/man/td_create.Rd +++ b/man/td_create.Rd @@ -30,5 +30,5 @@ Allocate a new histogram td <- td_create(10) } \references{ -\url{https://raw.githubusercontent.com/tdunning/t-Digest/master/docs/t-Digest-paper/histo.pdf} +\href{https://arxiv.org/abs/1902.04023}{Computing Extremely Accurate Quantiles Using t-Digests} } diff --git a/man/tquantile.Rd b/man/tquantile.Rd index 5f9ee4a..ebd9d77 100644 --- a/man/tquantile.Rd +++ b/man/tquantile.Rd @@ -32,5 +32,5 @@ tquantile(td, c(0, .01, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.99, 1)) quantile(td) } \references{ -\url{https://raw.githubusercontent.com/tdunning/t-Digest/master/docs/t-Digest-paper/histo.pdf} +\href{https://arxiv.org/abs/1902.04023}{Computing Extremely Accurate Quantiles Using t-Digests} }