extended testing for linux compatibility of all get_xattr* functions

tests/testthat/test-xattrs.R

@@ -8,63 +8,41 @@ test_that("we can do something", {
   expect_false(has_xattrs(tf))
   expect_identical(get_xattr(tf, "is.rud.setting"), character(0))
 
-  # setting attribute using respective OS tool and reading
-  #
+  # setting attribute using respective OS tool
   if(grepl("darwin", utils::sessionInfo()$platform)) {
-
     sys::exec_internal("xattr", arg = c("-w", ",is.rud.setting", "another attribute", tf), error = FALSE)
-    expect_true(has_xattrs(tf))
-    expect_identical(list_xattrs(tf), "is.rud.setting")
-    expect_identical(get_xattr(tf, "is.rud.setting"), "another attribute")
-    
-    # TO BE implemented with handle_user_prefix_{param,return}
-    expect_equal(get_xattr_size(tf, "is.rud.setting"), 17L)
-    expect_identical(class(get_xattr_df(tf)), c("tbl_df", "tbl", "data.frame"))
-
-    # continue testing    
-    expect_true(rm_xattr(tf, "is.rud.setting"))
   }
-  #
   if(grepl("linux", utils::sessionInfo()$platform)) {
-
     sys::exec_internal("attr", arg = c("-s", "is.rud.setting", "-V", "another attribute", tf), error = FALSE)
+  }
+  # reading and deleting with internal functions
+  if(grepl("darwin|linux", utils::sessionInfo()$platform)) {
+    # check attributes set with OS tool
     expect_true(has_xattrs(tf))
     expect_identical(list_xattrs(tf), "is.rud.setting")
     expect_identical(get_xattr(tf, "is.rud.setting"), "another attribute")
-
-    # TO BE implemented with handle_user_prefix_{param,return}
-    expect_equal(get_xattr_size(tf, "user.is.rud.setting"), 17L)
+    expect_equal(get_xattr_size(tf, "is.rud.setting"), 17L)
     expect_identical(class(get_xattr_df(tf)), c("tbl_df", "tbl", "data.frame"))
-    
-    # continue testing    
     expect_true(rm_xattr(tf, "is.rud.setting"))
   }
-  
-  # setting and reading attribute with internal functions
-  expect_true(set_xattr(tf, "is.rud.setting.a", "first attribut"))
-  
-  # TO BE implemented with handle_user_prefix_{param,return}
-  # expect_equal(get_xattr_size(tf, "user.is.rud.setting.a"), 14L)
 
-  # continue testing
+  # setting, reading, deleting attributes with internal functions
+  expect_true(set_xattr(tf, "is.rud.setting.a", "first attribut"))
+  expect_equal(get_xattr_size(tf, "is.rud.setting.a"), 14L)
   expect_true(has_xattrs(tf))
+  #
   expect_true(set_xattr(tf, "is.rud.setting.b", "second attribute"))
   expect_equal(get_xattr(tf, "is.rud.setting.b"), "second attribute")
-  
-  # TO BE implemented with handle_user_prefix_{param,return}
-  # expect_equal(get_xattr_size(tf, "user.is.rud.setting.b"), 16L)
-
-  # continue testing
+  expect_equal(get_xattr_size(tf, "user.is.rud.setting.b"), 16L)
+  #
   expect_true(set_xattr(tf, "is.rud.setting.a", "first attribute"))
   expect_equal(get_xattr(tf, "is.rud.setting.a"), "first attribute")
-  
-  # TO BE implemented with handle_user_prefix_{param,return}
-  # expect_equal(get_xattr_size(tf, "user.is.rud.setting.a"), 15L)
-
-  # continue testing
+  expect_equal(get_xattr_size(tf, "user.is.rud.setting.a"), 15L)
+  #
   expect_equal(length(list_xattrs(tf)), 2)
   expect_equal(nrow(get_xattr_df(tf)), 2)
   expect_true(rm_xattr(tf, "is.rud.setting.a"))
+  expect_false(suppressWarnings(rm_xattr(tf, "is.rud.setting.a")))
   expect_equal(get_xattr(tf, "is.rud.setting.a"), character(0))
 
   unlink(tf)